Add smb share feature for Chuangmi Camera #1482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested on chuangmi.camera.ip029a, working fine. |
rytilahti
reviewed
Oct 9, 2022
Co-authored-by: Teemu R. <tpr@iki.fi>
0x5e
force-pushed
the
feat/chuangmi-camera-smb-config
branch
from
773e035 to
c2dd1c8
Compare
rytilahti
changed the title
|
Hi @rytilahti , I updated the code for black and isort checks, still failed in mypy. I'm not familiar with pyhon3 syntax, could you help me solve this error? Thanks. |
|
Now linting checks has passed. |
rytilahti
reviewed
Oct 10, 2022
Co-authored-by: Teemu R. <tpr@iki.fi>
|
I executed this command on the 029a02 camera, it returned ['OK'] but did not actually write. How can I adapt 029a02? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Xiaomi App have limitation in setting NAS location, it has to be in the local network. It discover the NAS then list them then let me choose. I have a NAS across the VPN and actually it's accessible, but not able to be discovered and set.
This function can help people config NAS outside the local network.
Example:
miiocli chuangmicamera --ip 192.168.60.11 --token xxxxxxxxxx set_nas_config on "smb://user:pass@192.168.40.2/camera" realtime quarterIf the
shareparam left empty, It will keep the last config.Tested on
chuangmi.camera.ipc013