Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use attr.s instead attrs.define for homeassistant support #1503

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

rytilahti
Copy link
Owner

Home Assistant depends on an older attrs version that has no attrs module exported so this moves back from attrs.define to attr.s decorators for data class definitions.

@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2022

Codecov Report

Merging #1503 (a4f6b40) into master (0991f97) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1503      +/-   ##
==========================================
- Coverage   82.62%   82.62%   -0.01%     
==========================================
  Files         142      142              
  Lines       14081    14080       -1     
  Branches     3391     3391              
==========================================
- Hits        11634    11633       -1     
  Misses       2224     2224              
  Partials      223      223              
Impacted Files Coverage Δ
miio/descriptors.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit a4f6b40 into master Aug 15, 2022
@rytilahti rytilahti deleted the fix/fix_homeassistant_compatibility branch August 15, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants