Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose sensors, switches, and settings for zhimi.airhumidifier #1508

Merged
merged 4 commits into from
Sep 19, 2022

Conversation

Kirmas
Copy link
Contributor

@Kirmas Kirmas commented Aug 17, 2022

-sensor decorator
-switch decorator
-setting decorator

for correct working off this rytilahti/home-assistant#3 or similar changes must be merged

@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #1508 (0d1b897) into master (d544083) will increase coverage by 0.00%.
The diff coverage is 82.35%.

@@            Coverage Diff            @@
##           master    #1508     +/-   ##
=========================================
  Coverage   82.15%   82.15%             
=========================================
  Files         145      145             
  Lines       14161    14178     +17     
  Branches     3416     1608   -1808     
=========================================
+ Hits        11634    11648     +14     
- Misses       2302     2305      +3     
  Partials      225      225             
Impacted Files Coverage Δ
...iio/integrations/humidifier/zhimi/airhumidifier.py 90.24% <82.35%> (-0.72%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti changed the title Add decorator to AirHumidifierStatus: Expose sensors, switches, and settings for zhimi.airhumidifier Aug 26, 2022
miio/devicestatus.py Outdated Show resolved Hide resolved
miio/integrations/humidifier/zhimi/airhumidifier.py Outdated Show resolved Hide resolved
miio/integrations/humidifier/zhimi/airhumidifier.py Outdated Show resolved Hide resolved
miio/integrations/humidifier/zhimi/airhumidifier.py Outdated Show resolved Hide resolved
@Kirmas Kirmas force-pushed the kirmas/autodiscovery branch from f8ffb13 to 0d1b897 Compare September 9, 2022 06:05
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Kirmas, let's get this merged and worry about the units & extra metadata issues later when we get some more integrations converted!

@rytilahti rytilahti merged commit 3978f6c into rytilahti:master Sep 19, 2022
@Kirmas Kirmas deleted the kirmas/autodiscovery branch October 25, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants