-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix support for airqualitymonitor running firmware v4+ #1510
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1510 +/- ##
=========================================
Coverage 82.14% 82.15%
=========================================
Files 145 145
Lines 14156 14159 +3
Branches 1606 3416 +1810
=========================================
+ Hits 11629 11632 +3
Misses 2302 2302
Partials 225 225
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @WeslyG! 👍 I changed the description and the title, hopefully correctly, to make it more clear what was changed and why :-)
@rytilahti Thank you for accepting) |
in which version of home assistant will the fix be released? |
There is no formal release schedule, so it will be fixed at some point when I'll find some time to create a new release and the dependency gets bumped in homeassistant. The library is currently ongoing some larger changes and I'm busy with other responsibilities, so I'm not going to make any promises when that will happen. |
Still don't know when the update will be released? |
Hello @rytilahti , would be possible to update the release? I have two devices at home and unfortunately not able join them to HA :(. Thanks a lot! |
New firmware versions (v4+) for cgllc.airmonitor.s1 respond only with
["ok"]
when unsupported properties are requested.This PR removes the
battery
prop from the query to make it work on devices running running firmware versions.fixes #1489