Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for airqualitymonitor running firmware v4+ #1510

Merged
merged 1 commit into from
Aug 30, 2022
Merged

Fix support for airqualitymonitor running firmware v4+ #1510

merged 1 commit into from
Aug 30, 2022

Conversation

WeslyG
Copy link
Contributor

@WeslyG WeslyG commented Aug 19, 2022

New firmware versions (v4+) for cgllc.airmonitor.s1 respond only with ["ok"] when unsupported properties are requested.
This PR removes the battery prop from the query to make it work on devices running running firmware versions.

fixes #1489

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2022

Codecov Report

Merging #1510 (5850e27) into master (13d6f4a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           master    #1510     +/-   ##
=========================================
  Coverage   82.14%   82.15%             
=========================================
  Files         145      145             
  Lines       14156    14159      +3     
  Branches     1606     3416   +1810     
=========================================
+ Hits        11629    11632      +3     
  Misses       2302     2302             
  Partials      225      225             
Impacted Files Coverage Δ
miio/airqualitymonitor.py 84.16% <100.00%> (+0.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @WeslyG! 👍 I changed the description and the title, hopefully correctly, to make it more clear what was changed and why :-)

@rytilahti rytilahti changed the title Airmonitor after upgrading, does not transmit battery status Fix support for airqualitymonitor running firmware v4+ Aug 30, 2022
@rytilahti rytilahti merged commit bc97d6a into rytilahti:master Aug 30, 2022
@WeslyG WeslyG deleted the fixl/airmonitor-1396 branch August 30, 2022 20:45
@WeslyG
Copy link
Contributor Author

WeslyG commented Aug 30, 2022

@rytilahti Thank you for accepting)

@AntoxaSa
Copy link

AntoxaSa commented Sep 8, 2022

in which version of home assistant will the fix be released?

@rytilahti
Copy link
Owner

There is no formal release schedule, so it will be fixed at some point when I'll find some time to create a new release and the dependency gets bumped in homeassistant. The library is currently ongoing some larger changes and I'm busy with other responsibilities, so I'm not going to make any promises when that will happen.

@akarpych
Copy link

Still don't know when the update will be released?

@petron1e
Copy link

petron1e commented Apr 2, 2023

Hello @rytilahti , would be possible to update the release? I have two devices at home and unfortunately not able join them to HA :(. Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Qingping Air Monitor firmware update breaks request - Root Cause Identified
6 participants