Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dreame trouver finder vacuum #1514

Merged
merged 3 commits into from
Aug 24, 2022

Conversation

Massl123
Copy link
Contributor

I have added support for the Dreame Trouver Finder Vacuum Robot.
Fixes #1042

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Massl123! Could you update the list of supported devices in README.md, then this is good to go.

@Massl123
Copy link
Contributor Author

Sure!

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022

Codecov Report

Merging #1514 (1b223c7) into master (13d6f4a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           master    #1514     +/-   ##
=========================================
  Coverage   82.14%   82.15%             
=========================================
  Files         145      145             
  Lines       14156    14158      +2     
  Branches     1606     3415   +1809     
=========================================
+ Hits        11629    11631      +2     
  Misses       2302     2302             
  Partials      225      225             
Impacted Files Coverage Δ
...io/integrations/vacuum/dreame/dreamevacuum_miot.py 74.53% <100.00%> (+0.15%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit ee94732 into rytilahti:master Aug 24, 2022
@Massl123 Massl123 deleted the dreame_trouver_finder branch August 24, 2022 18:07
@xmaxtclub
Copy link

fantastic, I managed to configure it, I can start it, I see the map, the only thing that doesn't work for me is the cleaning by choosing the rooms. it makes me select it and gives me an error.

dreame.vacuum.p2036 (Trouver LDS Finder)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add xiaomi trouver lds finder support
4 participants