Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip write-only properties for miot status requests #1525

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

rytilahti
Copy link
Owner

This PR changes get_properties_for_mapping to ignore write-only properties for requests.
The requests will also now only contain only the expected keys (did, siid, piid) even if the mapping defines some extras.

Fixes #1376

@rytilahti rytilahti added the bug label Sep 14, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1525 (925aa13) into master (13d6f4a) will increase coverage by 0.02%.
The diff coverage is 76.92%.

@@            Coverage Diff             @@
##           master    #1525      +/-   ##
==========================================
+ Coverage   82.14%   82.17%   +0.02%     
==========================================
  Files         145      145              
  Lines       14156    14176      +20     
  Branches     1606     3419    +1813     
==========================================
+ Hits        11629    11649      +20     
+ Misses       2302     2299       -3     
- Partials      225      228       +3     
Impacted Files Coverage Δ
miio/miot_device.py 88.15% <76.92%> (+6.61%) ⬆️
miio/push_server/server.py 24.08% <0.00%> (-0.54%) ⬇️
miio/devicestatus.py 93.93% <0.00%> (ø)
miio/gateway/alarm.py 47.72% <0.00%> (ø)
miio/push_server/serverprotocol.py 25.75% <0.00%> (ø)
...integrations/airpurifier/zhimi/airpurifier_miot.py 81.73% <0.00%> (ø)
...io/integrations/vacuum/dreame/dreamevacuum_miot.py 74.61% <0.00%> (+0.23%) ⬆️
miio/airqualitymonitor.py 84.16% <0.00%> (+0.40%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fetching non-readables still return a success but no value (dreame.vacuum.mc1808)
2 participants