Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use typing.List for devtools/pcapparser #1530

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

rytilahti
Copy link
Owner

As pcapparser is now shipped and exposed through the cli, and we still support python 3.8, we need to use the generics from typing.

Thanks to @NEoKhajitt for reporting this in #1385!

@rytilahti rytilahti added the bug label Sep 18, 2022
@NEoKhajitt
Copy link

CI / Perform linting checks (3.10) (pull_request) is failing due to Could not parse version constraint: there is a problem in the poetry 1.2.1 package when testing local I had the same issue and you have to downgrade to poetry 1.2.0 on Windows env.

@rytilahti
Copy link
Owner Author

rytilahti commented Sep 19, 2022

The CI error is probably described in python-poetry/poetry#6519 (the failing constraint being ^0, but I cannot currently reproduce this locally so I don't know which dependency of ours it was..) but I wasn't able to confirm that the linked PR works for it. As I don't like the idea of pinning the build system version, let's see if it gets fixed when a new poetry-core with that PR is released.

@rytilahti rytilahti merged commit 3cb6ae1 into master Sep 20, 2022
@rytilahti rytilahti deleted the fix/pcapparser_python38_support branch September 20, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants