Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer newest, released release for miottemplate #1540

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Sep 26, 2022

Previously, miottemplate downloaded the first match when multiple were responded. This PR changes the behavior to download the newest, released (status=released) schema file.

This also fixes the previously broken download functionality.

Looks like miottemplate was also broken, this fixes it to make it simpler to get mapping files to test the simulator.
@rytilahti rytilahti added the bug label Sep 26, 2022
@rytilahti rytilahti changed the title Prefer released, newest releases for miottemplate Prefer newest, released release for miottemplate Sep 26, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #1540 (a6896e5) into master (a1ff575) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1540   +/-   ##
=======================================
  Coverage   81.95%   81.95%           
=======================================
  Files         149      149           
  Lines       14594    14594           
  Branches     3550     3550           
=======================================
  Hits        11960    11960           
  Misses       2387     2387           
  Partials      247      247           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit 6d841e0 into master Sep 26, 2022
@rytilahti rytilahti deleted the fix/miottemplate_invalid_accesses branch September 26, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants