-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multi map handling to roborock #1596
Conversation
@rytilahti ready for review/merge |
@rytilahti thanks for the quick revieuws the last few days, really making great progress! |
@rytilahti could you have a look at this and merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have had these pending reviews for a while, but didn't want to send them before offering a solution for some of them. Considering I'm busy with other things at the moment, I thought I'll just send the feedback as-is. Please take a look @starkillerOG and let me know what you think.
Also, you could create a PR for the part 2 (or merge with this?), if you think it will make it simpler to review the concepts.
@rytilahti I finished processing all feedback, can you have another look? |
@rytilahti All checks pass now, the error is unrelated. But because part 2 builds upon part 1 I will get lots of merge conflicts when we change stuff in part 1. I think this part 1 is really straight forward and can be merged quite fast. |
@rytilahti could you look at my responses/merge? |
Codecov Report
@@ Coverage Diff @@
## master #1596 +/- ##
==========================================
- Coverage 80.70% 80.69% -0.01%
==========================================
Files 157 157
Lines 15420 15480 +60
Branches 3427 3443 +16
==========================================
+ Hits 12445 12492 +47
- Misses 2719 2731 +12
- Partials 256 257 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@rytilahti I have finished processing your feedback, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is good to go as soon as the CI passes, thanks @starkillerOG! 👍 edit: could you please add tests that MapList
is parsed properly (and property accesses return what's expected)?
@rytilahti I added the test you suggested,
|
@rytilahti I included the test you requested, and it is now passing. |
The codecov still fails due to decreased coverage, but as some other parts are not covered either I'll let it slip this time, thanks again! Btw, if you click on the codecov links you can see what parts were covered and what not: https://app.codecov.io/gh/rytilahti/python-miio/pull/1596 |
Thanks, I will start working on the final part of the multi maps handeling |
Split out from #1543
Add basic multi map support to roborock vacuums
Later PR will add clean details per floor and floor information to last clean details.