Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent constructor signatures for device classes #1606

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

rytilahti
Copy link
Owner

@rytilahti rytilahti commented Nov 28, 2022

This makes all __init__() parameters consistent for Device-derived classes.

@codecov-commenter
Copy link

codecov-commenter commented Nov 28, 2022

Codecov Report

Merging #1606 (03955af) into master (1756fbc) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1606      +/-   ##
==========================================
+ Coverage   80.69%   80.72%   +0.02%     
==========================================
  Files         157      157              
  Lines       15417    15417              
  Branches     3427     3427              
==========================================
+ Hits        12441    12445       +4     
+ Misses       2724     2716       -8     
- Partials      252      256       +4     
Impacted Files Coverage Δ
miio/integrations/vacuum/viomi/viomivacuum.py 59.36% <ø> (ø)
miio/airconditioningcompanion.py 97.44% <100.00%> (ø)
miio/airconditioningcompanionMCN.py 85.36% <100.00%> (+1.21%) ⬆️
miio/gateway/gateway.py 44.16% <100.00%> (ø)
miio/huizuo.py 70.00% <100.00%> (+1.30%) ⬆️
miio/integrations/fan/dmaker/fan.py 94.84% <100.00%> (ø)
miio/integrations/fan/dmaker/fan_miot.py 90.64% <100.00%> (ø)
miio/integrations/light/yeelight/yeelight.py 79.60% <100.00%> (ø)
miio/integrations/vacuum/roborock/vacuum.py 62.21% <100.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti changed the title Fix inconsistent ctor signature for roborock Fix inconsistent ctor signatures for device classes Nov 28, 2022
@rytilahti rytilahti changed the title Fix inconsistent ctor signatures for device classes Fix inconsistent constructor signatures for device classes Nov 28, 2022
@rytilahti rytilahti merged commit 4911ea2 into master Nov 28, 2022
@rytilahti rytilahti deleted the fix/roborock_signature branch November 28, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants