Use micloud for miotspec cloud connectivity #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
rytilahti
force-pushed
the
genericmiot/use_miotspec_from_micloud
branch
from
66aa3be to
d67c2f6
Compare
rytilahti
force-pushed
the
genericmiot/use_miotspec_from_micloud
branch
from
517ccd1 to
d08d12e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1610 +/- ##
==========================================
- Coverage 80.41% 80.41% -0.01%
==========================================
Files 161 161
Lines 16024 16026 +2
Branches 3613 3558 -55
==========================================
+ Hits 12886 12887 +1
- Misses 2875 2883 +8
+ Partials 263 256 -7
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert miot_cloud to use micloud.MiotSpec for cloud accesses.
This PR also makes micloud a mandatory dependency, at least for the time being.