Extended Air Conditioning Companion support #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syssi
changed the title
1 similar comment
houndci-bot
reviewed
Jan 21, 2018
miio/airconditioningcompanion.py
Outdated
| configuration = configuration.replace('mo', operation_mode.value) | ||
| configuration = configuration.replace('wi', fan_speed.value) | ||
| configuration = configuration.replace('sw', swing_mode.value) | ||
| configuration = configuration.replace('tt', hex(int(target_temperature))[2:]) |
There was a problem hiding this comment.
line too long (85 > 79 characters)
miio/airconditioningcompanion.py
Outdated
| swing_mode: SwingMode): | ||
|
|
||
| # Static turn off command available? | ||
| if (power == False) and (model in DEVICE_COMMAND_PRESETS) and \ |
There was a problem hiding this comment.
comparison to False should be 'if cond is False:' or 'if not cond:'
syssi
changed the title
houndci-bot
reviewed
Jan 22, 2018
| if model in DEVICE_COMMAND_TEMPLATES: | ||
| configuration = model + DEVICE_COMMAND_TEMPLATES[model]['base'] | ||
| else: | ||
| configuration = model + DEVICE_COMMAND_TEMPLATES['fallback']['base'] |
There was a problem hiding this comment.
line too long (80 > 79 characters)
rytilahti
reviewed
Jan 23, 2018
miio/airconditioningcompanion.py
Outdated
| else: | ||
| configuration = model + DEVICE_COMMAND_TEMPLATES['fallback']['base'] | ||
|
|
||
| configuration = configuration.replace('po', power.value) |
There was a problem hiding this comment.
Just a suggestion, would it be better to replace placeholders with something like [PO] to make it more clear that they are placeholders? Just a thought though, otherwise this seems fine to me so please feel to merge when you want.
houndci-bot
reviewed
Jan 26, 2018
| }, | ||
| '0100010727': { | ||
| 'deviceType': 'gree_2', | ||
| 'base': '[po][mo][wi][sw][tt]1100190[tt1]205002102000t7t0190[tt1]207002000000[tt4]0', |
There was a problem hiding this comment.
line too long (93 > 79 characters)
| POWER_OFF = 'off' | ||
|
|
||
| # Command templates per model number (f.e. 0180111111) | ||
| # [po], [mo], [wi], [sw], [tt], [tt1], [tt4] and [tt7] are markers which will be replaced |
There was a problem hiding this comment.
line too long (89 > 79 characters)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.