-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add parent reference to embedded containers #1711
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1711 +/- ##
=======================================
Coverage 81.74% 81.74%
=======================================
Files 191 191
Lines 17935 17937 +2
Branches 3845 3845
=======================================
+ Hits 14661 14663 +2
Misses 2986 2986
Partials 288 288
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not make some changes to getattr of DeviceStatus to make sure a embeded container can acces the master/other embeded properties?
The embedded container can use |
@rytilahti I ment we could make it such that we can use |
You can already access the parent as well as other embedded containers like this:
Is that not enough for the use case at hand? |
@rytilahti fair, I think this will surfice, we will do it as you illustrated. |
I tested this and it is working. I implemented it in the Roborock multi map PR: #1614 |
Allows embedded containers to access data from other embeddeds or the main status.