Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported settings first after initialization is done #1736

Merged
merged 1 commit into from
Feb 16, 2023

Conversation

rytilahti
Copy link
Owner

We cannot modify the container we are iterating as it causes RuntimeError: dictionary changed size during iteration (@starkillerOG).

Closes #1702

@rytilahti rytilahti added the bug label Feb 16, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 16, 2023

Codecov Report

Merging #1736 (a1eabec) into master (2a33f41) will decrease coverage by 0.01%.
The diff coverage is 25.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1736      +/-   ##
==========================================
- Coverage   81.93%   81.92%   -0.01%     
==========================================
  Files         196      196              
  Lines       18054    18057       +3     
  Branches     3863     3864       +1     
==========================================
+ Hits        14793    14794       +1     
- Misses       2972     2973       +1     
- Partials      289      290       +1     
Impacted Files Coverage Δ
miio/device.py 81.21% <25.00%> (-0.81%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit 53a1c52 into master Feb 16, 2023
@rytilahti rytilahti deleted the fix/choices_attribute_fix branch February 16, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix settings request when retrieve_choices_function() fails
2 participants