Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement __cli_output__ for descriptors #1762

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

rytilahti
Copy link
Owner

This is a step toward making a standard, descriptor-based API to the cli tool.

This is a step forward to make a common, descriptor-based API to the cli tool.
@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Merging #1762 (1707311) into master (f060159) will decrease coverage by 0.06%.
The diff coverage is 55.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master    #1762      +/-   ##
==========================================
- Coverage   80.75%   80.69%   -0.06%     
==========================================
  Files         193      193              
  Lines       18471    18511      +40     
  Branches     3996     4010      +14     
==========================================
+ Hits        14916    14938      +22     
- Misses       3286     3296      +10     
- Partials      269      277       +8     
Impacted Files Coverage Δ
miio/descriptors.py 81.44% <55.00%> (-18.56%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit 9ab2ae4 into master Mar 8, 2023
@rytilahti rytilahti deleted the feat/cli_output_for_descriptors branch March 8, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants