Add repeat param to Roborock segment clean
#1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rytilahti
approved these changes
May 6, 2023
There was a problem hiding this comment.
Thanks for the PR, I think this is good to go (the linting checks are unrelated)!
The earlier format might be what earlier firmware versions used, but I think this is fine to merge. If someone is using this and we get bug reports about incorrect behavior, we can adjust the payload based on the version information.
|
Thanks for the merge! I will probably be also adding support for that in Home Assistant after the next release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! This is actuall fix for #1034, for some reason, this issue was closed with sketchy workarounds.
I've added
repeatprop forsegment_cleanfunction inRoborockVacuum. This represents the count of repeats that the vacuum does in specified segments:This is done as specified in XiaomiRobotVacuumProtocol. I've tested this with my Roborock S5 Max and it works well.