Make sure cache directory exists for miotcloud #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests for the expected behavior. Also, requesting release info for a non-existing model will now raise CloudException instead of Exception.
Codecov Report
@@ Coverage Diff @@
## master #1798 +/- ##
==========================================
+ Coverage 80.70% 80.85% +0.15%
==========================================
Files 192 192
Lines 18511 18513 +2
Branches 4012 4011 -1
==========================================
+ Hits 14939 14969 +30
+ Misses 3295 3266 -29
- Partials 277 278 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
CI errors are unrelated, so I'll just merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for the expected behavior.
Also, requesting release info for a non-existing model will now raise CloudException instead of Exception.
Fixes #1785