Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dreamevacuum: don't crash on missing property values #1831

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

rytilahti
Copy link
Owner

Do not crash if the dreamevacuum property does not contain a value.

Fixes #1822

@rytilahti rytilahti added the bug label Sep 24, 2023
@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #1831 (dc96cbf) into master (8f567fe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1831   +/-   ##
=======================================
  Coverage   80.80%   80.80%           
=======================================
  Files         192      192           
  Lines       18546    18546           
  Branches     4012     4012           
=======================================
  Hits        14986    14986           
  Misses       3282     3282           
  Partials      278      278           
Files Changed Coverage Δ
...io/integrations/dreame/vacuum/dreamevacuum_miot.py 74.47% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit 81d28ec into master Oct 4, 2023
16 of 18 checks passed
@rytilahti rytilahti deleted the dreamevacuum/fix/missing_values branch October 4, 2023 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception KeyError: 'value' on Dreamevacuum status
1 participant