Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use __cli_output__ for info() #1847

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Conversation

rytilahti
Copy link
Owner

Move output formatting into DeviceInfo class.

Base automatically changed from refactor/descriptorcollection to master October 20, 2023 22:56
@rytilahti rytilahti force-pushed the refactor/deviceinfo_cli_output branch from f514bf4 to f8ce619 Compare October 20, 2023 23:10
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #1847 (f8ce619) into master (72880ae) will increase coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1847      +/-   ##
==========================================
+ Coverage   81.34%   81.41%   +0.07%     
==========================================
  Files         193      193              
  Lines       18555    18556       +1     
  Branches     4023     4024       +1     
==========================================
+ Hits        15094    15108      +14     
+ Misses       3186     3173      -13     
  Partials      275      275              
Files Coverage Δ
miio/device.py 94.00% <100.00%> (+5.80%) ⬆️
miio/deviceinfo.py 100.00% <100.00%> (+3.22%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rytilahti rytilahti merged commit 59f6b15 into master Oct 21, 2023
16 of 18 checks passed
@rytilahti rytilahti deleted the refactor/deviceinfo_cli_output branch October 21, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant