Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for dmaker.fan.p45 #1853

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Conversation

saxel
Copy link
Contributor

@saxel saxel commented Oct 21, 2023

No description provided.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #1853 (f2cf743) into master (501a7d7) will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1853      +/-   ##
==========================================
- Coverage   81.41%   81.40%   -0.02%     
==========================================
  Files         193      193              
  Lines       18556    18567      +11     
  Branches     4024     4026       +2     
==========================================
+ Hits        15108    15115       +7     
- Misses       3169     3171       +2     
- Partials      279      281       +2     
Files Coverage Δ
miio/integrations/dmaker/fan/fan_miot.py 89.30% <66.66%> (-1.61%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, btw, the genericmiot should be able to control this device too. Have you tried it out in the current git master?

@saxel
Copy link
Contributor Author

saxel commented Oct 21, 2023

Yes, the genericmiot seems to be able to control the fan just fine on master branch.

@rytilahti
Copy link
Owner

Great, the thing with genericmiot is that while it offers an universal support, it requires online access so having something functioning as-is can be useful. There may also be existing users of fanimiot, so extending the support for those sounds fair, so let's get this merged for the upcoming release. Thanks for the PR! 👍

@rytilahti rytilahti merged commit 4c81530 into rytilahti:master Oct 21, 2023
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants