-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Xiaomi Smart Space Heater 1S (zhimi.heater.mc2a) #1868
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1868 +/- ##
=======================================
Coverage 81.40% 81.40%
=======================================
Files 193 193
Lines 18563 18563
Branches 4024 4024
=======================================
Hits 15112 15112
Misses 3174 3174
Partials 277 277 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! 👍
In the future it will be easier to control these devices using the genericmiot
integration, but that will require much more rewiring (that I've been slowly doing on my own..) so this will be a good stop-gap solution until that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, please split the PR into two, one per each device.
I removed the p39 code and merged the recent changes into my branch but for some reason now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are known to be flaky, no worries on that :-)
This PR adds support for Xiaomi Smart Space Heater 1S (zhimi.heater.mc2a).
Changes are minimal as the mc2a is basically identical to the mc2.
I own the device myself and can confirm that everything reads and performs as expected.
I would appreciate a quick merge as this is only the first step on my journey to natively integrate both devices into the main "Xiaomi" integration for Home Assistant.
Thanks a lot for the amazing foundation!