Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Xiaomi Smart Space Heater 1S (zhimi.heater.mc2a) #1868

Merged
merged 5 commits into from
Dec 6, 2023
Merged

Added support for Xiaomi Smart Space Heater 1S (zhimi.heater.mc2a) #1868

merged 5 commits into from
Dec 6, 2023

Conversation

paranerd
Copy link
Contributor

@paranerd paranerd commented Dec 3, 2023

This PR adds support for Xiaomi Smart Space Heater 1S (zhimi.heater.mc2a).
Changes are minimal as the mc2a is basically identical to the mc2.

I own the device myself and can confirm that everything reads and performs as expected.

I would appreciate a quick merge as this is only the first step on my journey to natively integrate both devices into the main "Xiaomi" integration for Home Assistant.

Thanks a lot for the amazing foundation!

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (93030e8) 81.40% compared to head (b5f3fe3) 81.40%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1868   +/-   ##
=======================================
  Coverage   81.40%   81.40%           
=======================================
  Files         193      193           
  Lines       18563    18563           
  Branches     4024     4024           
=======================================
  Hits        15112    15112           
  Misses       3174     3174           
  Partials      277      277           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paranerd paranerd changed the title Added support for Xiaomi Smart Space Heater 1S (zhimi.heater.mc2a) Added support for Xiaomi Smart Space Heater 1S (zhimi.heater.mc2a) and Xiaomi Tower Fan (dmaker.fan.p39) Dec 3, 2023
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

In the future it will be easier to control these devices using the genericmiot integration, but that will require much more rewiring (that I've been slowly doing on my own..) so this will be a good stop-gap solution until that.

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, please split the PR into two, one per each device.

@paranerd paranerd changed the title Added support for Xiaomi Smart Space Heater 1S (zhimi.heater.mc2a) and Xiaomi Tower Fan (dmaker.fan.p39) Added support for Xiaomi Smart Space Heater 1S (zhimi.heater.mc2a) Dec 5, 2023
@paranerd
Copy link
Contributor Author

paranerd commented Dec 5, 2023

I removed the p39 code and merged the recent changes into my branch but for some reason now macos-latest and windows-latest CI checks seem to be randomly failing - any ideas?

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are known to be flaky, no worries on that :-)

@rytilahti rytilahti merged commit 658ee2e into rytilahti:master Dec 6, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants