Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sphinx config fix #458

Merged
merged 3 commits into from
Jan 20, 2019
Merged

Sphinx config fix #458

merged 3 commits into from
Jan 20, 2019

Conversation

domibarton
Copy link
Contributor

Fixed some minor things in the config. Please have a look at the changes & commit messages for more infos.

We don't want those directories commited to the git repository.

Python virtual environments are often created in a .venv/ directory,
thus ignoring all .venv/ directories.

The docs/_build directory is automatically created by Sphinx when the
documentation is generated. We don't want the generated documentation
to be commited to the repository.
This is required because if someone stores the virtualenv in a .venv
directory (common practice) under the docs/ path, then Sphinx will try
to pickup all files under the virtualenv. This leads to a lot of errors,
performance impacts and side effects.
There are currently no additional static files for Sphinx in place,
but there's a _static directory configured in the Sphinx docs. When
creating the Sphinx docs without an `mkdocs _static` command before,
this leads to an error.

Thus removing the _static path until we need it again.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 72.461% when pulling a23203e on confirm:sphinx-config-fix into 07102a8 on rytilahti:master.

@rytilahti
Copy link
Owner

Looks good, thanks for improving the documentation! 🥇

@rytilahti rytilahti merged commit 6b2ce47 into rytilahti:master Jan 20, 2019
@domibarton domibarton deleted the sphinx-config-fix branch January 24, 2019 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants