Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STYJ02YM: Manual movement and mop mode support #590

Merged
merged 6 commits into from
Dec 22, 2019
Merged

STYJ02YM: Manual movement and mop mode support #590

merged 6 commits into from
Dec 22, 2019

Conversation

rumpeltux
Copy link
Contributor

@coveralls
Copy link

coveralls commented Dec 5, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.04%) to 72.596% when pulling 3120efa on rumpeltux:viomi into 1a52117 on rytilahti:master.

rytilahti
rytilahti approved these changes Dec 5, 2019
View reviewed changes
Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, besides the naming of is_mop property which should be changed.

miio/viomivacuum.py Show resolved Hide resolved
@petrkotek petrkotek mentioned this pull request Dec 8, 2019
Merged
@rytilahti
Copy link
Owner

Thanks, merging! 🎉

@rytilahti rytilahti merged commit bbd844f into rytilahti:master Dec 22, 2019
@rytilahti rytilahti mentioned this pull request Dec 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rytilahti rytilahti rytilahti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rumpeltux @coveralls @rytilahti