Add extra_parameters to send() #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows passing extra items to the main payload body, necessary for adding support for subdevices. This also includes some slight cleanups and better tests for the protocol handling code. Related to #651
|
Small bug in there, see 820cdfe |
|
Ouch, I'll check that out and write more tests, that should not have happened... |
|
I'll merge this so that #651 can proceed. |
xvlady
pushed a commit
to xvlady/python-miio
that referenced
this pull request
May 9, 2021
* Add extra_parameters to send() This allows passing extra items to the main payload body, necessary for adding support for subdevices. This also includes some slight cleanups and better tests for the protocol handling code. Related to rytilahti#651 * Fix build * Fix incorrect access, thanks to @fsalomon for pointing this out!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows passing extra items to the main payload body,
necessary for adding support for subdevices.
This also includes some slight cleanups and better tests for the protocol handling code.
Related to #651