Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xiaomi Zero Fog Humidifier (shuii.humidifier.jsq001) support (#642) #654

Merged
merged 6 commits into from
Mar 28, 2020

Conversation

iromeo
Copy link
Contributor

@iromeo iromeo commented Mar 27, 2020

Adds support for shuii.humidifier.jsq001 humidifier (#642)

@coveralls
Copy link

coveralls commented Mar 27, 2020

Coverage Status

Coverage increased (+0.4%) to 73.181% when pulling d281cc3 on iromeo:master into 86de386 on rytilahti:master.

Copy link
Owner

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! See the inline commentary for a short review.

miio/airhumidifier_jsq.py Outdated Show resolved Hide resolved
miio/airhumidifier_jsq.py Outdated Show resolved Hide resolved
miio/airhumidifier_jsq.py Outdated Show resolved Hide resolved
miio/airhumidifier_jsq.py Outdated Show resolved Hide resolved
miio/airhumidifier_jsq.py Outdated Show resolved Hide resolved
miio/airhumidifier_jsq.py Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@iromeo
Copy link
Contributor Author

iromeo commented Mar 28, 2020

@rytilahti seems everything is ready, thank you for the detailed review

@rytilahti rytilahti merged commit e181169 into rytilahti:master Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants