Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AqaraSmartBulbE27 support #729

Merged
merged 3 commits into from
Jun 20, 2020
Merged

Conversation

starkillerOG
Copy link
Contributor

Also add untested bind commands to docstring from #295

Add AqaraSmartBulbE27 support from https://github.com/igzero/xiaomigateway

Note that the self._props.color_temp = self.send("get_ct").pop() is untested but that seemed to be a very good guess as:
set_ct
set_bright
get_bright
are implemented in https://github.com/igzero/xiaomigateway

Also add untested bind commands to docstring
@starkillerOG
Copy link
Contributor Author

@igzero Could you test this code?
If so it will be straigt forward to add the bulb to HomeAssistant in the official xiaomi_miio component.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 74.218% when pulling 8320f6f on starkillerOG:patch-10 into 8a88057 on rytilahti:master.

@starkillerOG
Copy link
Contributor Author

@rytilahti can you merge this?
All tests pass (except coverage)

@starkillerOG
Copy link
Contributor Author

@mouth4war did you test this code?

@rytilahti
Copy link
Owner

Sure thing! I think we should start adding some tests for the gateway to avoid breaking it inadverently in the future. That's probably best done in sync with refactoring the file into its own package as discussed earlier.

@rytilahti rytilahti merged commit de28e85 into rytilahti:master Jun 20, 2020
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
* Add AqaraSmartBulbE27 support

Also add untested bind commands to docstring

* fix black styling

* fix flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants