fan: Ability to disable delayed turn off functionality #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When 0 is passed, delay turn off is disabled. Before this, if delay off was set, it could not be unset.
This was referenced Jun 30, 2020
|
LGTM after the tests pass. What do you think @syssi? |
syssi
approved these changes
Jun 30, 2020
|
The tests should be updated, too. |
rytilahti
changed the title
|
Thanks guys! |
xvlady
pushed a commit
to xvlady/python-miio
that referenced
this pull request
May 9, 2021
* Added ability to disable delayed turn off functionality When 0 is passed, delay turn off is disabled. Before this, if delay off was set, it could not be unset. * Update test_fan.py * Update test_fan.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 0 is passed, delay turn off is disabled. Before this, if delay off was set, it could not be unset.