-
-
Notifications
You must be signed in to change notification settings - Fork 563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "lumi.acpartner.v3" since it also works with this code #769
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I'm not sure how this should be properly handled. There is miio/airconditioningcompanion.py
which has this mode, so if both of these would be added to homeassistant it would double the number of requests, no?
Maybe the common functionality needs to be refactored out, assuming the API is really the same for both..
@rytilahti I was also supprised that the AC partner supported the same API. |
@rytilahti not sure what the best way is for the AC partner...... |
Since the |
Okay, fine by me. Maybe due time the specific gateway features are contained inside their own implementation files (e.g., alarm, light) that can be re-used on other gateways. I remember reading long time ago from somewhere that the gateways and ac partners share quite a bit of implementation which may not be that surprising as they are both developed by "lumi". |
…#769) * add "lumi.acpartner.v3" since it also works with this code * Update gateway.py
No description provided.