Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for lumi.acpartner.mcn02 #809

Merged
merged 1 commit into from
Sep 10, 2020
Merged

Conversation

EugeneLiu
Copy link
Contributor

@EugeneLiu EugeneLiu commented Sep 1, 2020

Add support for KTBL03LM (lumi.acpartner.mcn02).

Fixes #637

@coveralls
Copy link

coveralls commented Sep 1, 2020

Coverage Status

Coverage increased (+0.07%) to 74.019% when pulling f1bd5ef on EugeneLiu:master into 93b7a77 on rytilahti:master.

@EugeneLiu
Copy link
Contributor Author

@rytilahti I executed the command 'tox -e lint' locally. It's succeeded,but nothing to commit.I reapplied PR, no passing again.

@rytilahti
Copy link
Owner

Hmm, that's odd.. Anyway, the other PR (with fixes to linting) was just merged so what remains for you to do is to simply rebase this PR on top of the current master and the issue should disappear :-)

@EugeneLiu EugeneLiu force-pushed the master branch 3 times, most recently from 69174dd to cb87b49 Compare September 2, 2020 08:47
@EugeneLiu EugeneLiu closed this Sep 2, 2020
@EugeneLiu EugeneLiu reopened this Sep 2, 2020
@EugeneLiu
Copy link
Contributor Author

I find black version in .pre-commit-config.yaml different from pipline. I use 'https://github.com/psf/black' replace 'https://github.com/ambv/black' in .pre-commit-config.yaml file, so check passed. @rytilahti

@rytilahti
Copy link
Owner

Looks like the ambv/black forwards on github to psf/black, so it should be the same? Maybe the pinned version in poetry.lock is different?

Anyway, I think this can be merged now as the checks are passing, thanks for the PR! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for lumi.acpartner.mcn02 please?
3 participants