Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set timeout as parameter #866

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Set timeout as parameter #866

merged 2 commits into from
Nov 23, 2020

Conversation

titilambert
Copy link
Contributor

Make timeout as parameter for miio protocol
It will be useful for viomi vacuum

@titilambert titilambert mentioned this pull request Nov 23, 2020
Merged
syssi
syssi reviewed Nov 23, 2020
View reviewed changes
miio/device.py Outdated Show resolved Hide resolved
syssi
syssi approved these changes Nov 23, 2020
View reviewed changes
Copy link
Collaborator

@syssi syssi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged as soon the minor issue is fixed.

@titilambert @syssi
Update miio/device.py
f402481 
Co-authored-by: Sebastian Muszynski <basti@linkt.de>
@titilambert
Copy link
Contributor Author

Can be merged as soon the minor issue is fixed.

Done !
Thanks !

@syssi syssi merged commit 0601c61 into rytilahti:master Nov 23, 2020
@syssi
Copy link
Collaborator

syssi commented Nov 23, 2020

Good job! Thanks! 👍

@rytilahti rytilahti mentioned this pull request Mar 13, 2021
Merged
xvlady pushed a commit to xvlady/python-miio that referenced this pull request May 9, 2021
@titilambert @xvlady
Set timeout as parameter (rytilahti#866)
c765ed9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syssi syssi syssi approved these changes

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@titilambert @syssi @rytilahti