Fix the logic of staring cleaning a room for Viomi #946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexAlexPin
changed the title
|
@titilambert this one's for you :-) |
|
Considering there has been no response from @titilambert so far and I'd like to cut a release soonish, @AlexAlexPin could you confirm that you have tested this PR with a real device and this is okay to merge now? |
Yes, I tested it with |
|
Okay, thanks for the PR! Let's merge this now and in case it breaks something, it can be fixed later on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found an issue in
miio/viomivacuum.py start_with_room()Lines 633 and 635: the
room_idsis being appended and passed to vacuum as a string, that the vacuum doesn't understand.Line 642: According to the description in the method
start()the params[0, 1, 3, 11, 12, 13]= start cleaning rooms 11-13, but the line 642 build the line[0, 1, 0, 3, 11, 12, 13], that means that the length of the room ids array is 0. That makes the vacuum to make a full cleaning instead of cleaning a room.