Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restart and flash missing? #117

Open
kvikindi opened this issue Mar 17, 2024 · 4 comments
Open

restart and flash missing? #117

kvikindi opened this issue Mar 17, 2024 · 4 comments

Comments

@kvikindi
Copy link

I might be taking crazy pills here, but going by the commit history, it seems that all references to the LED flash and restart api have been removed in versions since at least 1.0.6?

Also I'm seeing references to the "version 2" branch under releases, but there's none to be found?

Please advise, as reality is already kind of funky these days 😄

@ulab
Copy link

ulab commented Mar 19, 2024

I'd think the "version 2" branch is "develop", but I agree, this is confusing.

@rzeldent
Copy link
Owner

Hi Ragnar,

No, you did not take any crazy pills! Version 2 was created to support more devices. This unfortunately required a common base and LED flash was removed. Restart was removed because this was only available after settings were changed and (if the type of the board is correct), restarting was no longer required.

@jsnyder
Copy link

jsnyder commented Apr 18, 2024

On the Seeed ESP32S3 Sense the settings don't seem to take effect without a restart though (at least resolution doesn't) or am I missing something (or still a work in progress to support)?

@acongdon
Copy link

Same on AI Thinker, change resolution settings OK but doesn't reboot to apply them... up the ladder again...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants