-
-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add s-pen button erasing #783
Conversation
Codecov Report
@@ Coverage Diff @@
## main #783 +/- ##
=======================================
Coverage 43.64% 43.64%
=======================================
Files 91 91
Lines 6384 6399 +15
=======================================
+ Hits 2786 2793 +7
- Misses 3598 3606 +8
|
@ZebraVogel94349 Thanks for this! Would you be able to test the new changes (mostly the part where the user is already drawing a stroke and presses the eraser button)? |
@adil192 I tested all new changes with my Tab S7 FE and the S-Pen and it's working fine. If a the user is already drawing a stroke and presses the eraser button, the currently drawn stroke gets removed and the eraser is selected. |
I'll merge this in now. Hopefully the flutter issue is fixed soonish! |
I think this change made it so it is now impossible to manually erase with the eraser. When I select the eraser and try to use it, it immediately switches back to the pen tool. Happens with both s pen and finger drawing. |
This should be fixed in #785 |
This adds the feature to switch to the eraser while the button on a stylus (tested with the Samsung S-Pen) is pressed and to switch back to the previous tool when the button is released, which is similar to the behavior in Samsung Notes.