Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more assets in invariant tests #137

Closed
andreivladbrg opened this issue May 28, 2024 · 0 comments · Fixed by #158
Closed

Add more assets in invariant tests #137

andreivladbrg opened this issue May 28, 2024 · 0 comments · Fixed by #158
Assignees
@andreivladbrg
Labels
effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect.

Comments

@andreivladbrg
Copy link
Member

andreivladbrg commented May 28, 2024 •
edited
Loading

The idea is to have 3 or 4 different types of assets in the invariant tests to be more precise.

assets with 1/6/18 decimals.
assets that either return or do not return a value

This is useful because we use only 18-decimal numbers internally.
@andreivladbrg andreivladbrg self-assigned this May 28, 2024
@andreivladbrg andreivladbrg added effort: high Large or difficult task. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. labels May 28, 2024
@andreivladbrg andreivladbrg mentioned this issue May 30, 2024
Closed
@smol-ninja smol-ninja mentioned this issue May 31, 2024
Closed
@andreivladbrg andreivladbrg mentioned this issue Jun 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreivladbrg andreivladbrg

Labels
effort: high Large or difficult task. priority: 2 We will do our best to deal with this. type: test Adding, updating, or removing tests. work: complex Probe-sense-respond. The relationship between cause and effect can only be perceived in retrospect.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add more assets in invariant tests sablier-labs/flow
1 participant
@andreivladbrg