Add more assets in invariant tests #158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smol-ninja
requested changes
Jun 6, 2024
Unless, we are going to use this array in integration tests, I think its better to keep it in Flow contract. |
andreivladbrg
force-pushed
the
test/more-invariant-assets
branch
from
f0695b2
to
6fa8fbf
Compare
test: add an array of assets in CreateHandler test: fuzz the asset in CreateHandler test: remove unneeded Invariant_Test contract test: remove checkUsers modifier test: move test contracts in BaseHandler test: run invariant_ContractBalanceGeStreamBalances test for all assets test: add a helper function to prevent stack too deep error test: use assume instead of "if() return"
andreivladbrg
force-pushed
the
test/more-invariant-assets
branch
from
6fa8fbf
to
628e595
Compare
|
@smol-ninja i've addressed your feedback, lmk if i missed anything |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issues
vm.assumein invariant handlers instead of returning #157Changes
FlowCreateHandleruseFuzzedAssetmodifier inFlowCreateHandlerInvariant_TestcontractFlowCreateHandlerto preventStack too deeperrorBaseHandlerinvariant_ContractBalanceGeStreamBalancestest for all assetsvm.assumeinstead ofif(condition) returnNote: I wanted to add the array of assets from
test/invariant/Flow.t.soltoBase_Test, but I didn’t do it to prevent git conflicts.