test: inequality in streamed amount invariant #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smol-ninja
reviewed
Oct 16, 2024
test: remove delay from store
andreivladbrg
force-pushed
the
test/inv-inequality
branch
from
f9a583e
to
60fdb8f
Compare
smol-ninja
changed the title
smol-ninja
changed the title
smol-ninja
changed the title
smol-ninja
force-pushed
the
test/inv-inequality
branch
2 times, most recently
from
2ca57d6
to
2fad05a
Compare
smol-ninja
requested changes
Oct 17, 2024
|
|
||
| assertEq( | ||
| totalStreamedAmountWithDelay, | ||
| assertLe( |
There was a problem hiding this comment.
I wonder why is there an "Le" here? Previously, we had the following relations:
$totalStreamedAmount \ge totalStreamedAmountWithDelay$ $totalStreamedAmountWithDelay = totalDebt + totalWithdrawn$
Therefore from the above two, the new relation should be
$totalStreamedAmount \ge totalDebt + totalWithdrawn$
and not the opposite.
smol-ninja
force-pushed
the
test/inv-inequality
branch
from
2fad05a
to
45436e9
Compare
smol-ninja
approved these changes
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #307