docs: update protocol assumptions #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRBerg
approved these changes
Oct 17, 2024
|
Yeah go ahead @PaulRBerg |
|
Thanks, good to merge now. We might want to add the same assumption about the admin in the Lockup security document. |
|
Thank you. Yes there is a separate issue to track that: sablier-labs/v2-core#1065. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update protocol assumption post Cantina finding. Also added assumption about tokens with admin powers as pointed by @razgraf on Slack.
Closes #310.
@andreivladbrg I have replaced the "delay" keyword with "precision errors" and "loss" as thats what Cantina auditors used in their submissions. I think these terms are easier to follow compared to "delay" keywords.