build: node.js set-up #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRBerg
force-pushed
the
build/node-js
branch
3 times, most recently
from
406862e
to
d451d6d
Compare
andreivladbrg
requested changes
May 15, 2023
There was a problem hiding this comment.
Let's create all necessary directories before compiling with forge:
...
# Create necessary directories
mkdir -p "$artifacts/interfaces/erc20" \
"$artifacts/interfaces/erc721" \
"$artifacts/interfaces/hooks" \
"$artifacts/libraries"
...
This approach will improve readability
|
Good idea |
chore: git ignore "artifacts" chore: include "artifacts" in "clean" script ci: update paths passed to "actions/upload-artifact" Closes #389
|
Implemented your suggestion and merged the PR now, @andreivladbrg. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #389 and #439.