Refactor "cancelAll", "withdrawAll" and "withdrawAllTo" #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRBerg
force-pushed
the
refactor/all-functions
branch
from
b181d21 to
3b49c24
Compare
3 tasks
PaulRBerg
force-pushed
the
refactor/all-functions
branch
from
3b49c24 to
e09d57a
Compare
chore: improve wording and fix typos in comments docs: fix typos in NatSpec comments refactor: "cancelAll" function to not revert when some streams are not cancelable refactor: inherit "getRecipient", "getSender" and "isCancelable" in "SablierV2" abstract contract" test: combine the "cancel the stream" and "delete the stream" branches test: combine the "make the withdrawal" and "update the withdrawn amounts" branches test: improve wording in comments, descriptors and test trees test: rewrite "cancelAll", "withdrawAll" and "withdrawAllTo" tests test: test for just "WITHDRAW_AMOUNT" instead of "stream.withdrawnAmount + WITHDRAW_AMOUNT"
PaulRBerg
force-pushed
the
refactor/all-functions
branch
from
e09d57a to
06d4d60
Compare
test: fix typo in descriptor for "testWithdraw__StreamEnded" function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
And in addition:
Depends upon #65 and #68 being merged first.