Merge the "create" and "createFrom" function #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaulRBerg
force-pushed
the
refactor/merge-create-functions
branch
3 times, most recently
from
9b8a6b2
to
4bbac8c
Compare
PaulRBerg
changed the title
chore: improve wording in comments docs: be more specific in description for "sender" argument docs: improve wording in NatSpec refactor: add "funder" to "CreateStream" events refactor: mark "funder" as indexed instead of "streamId" in events refactor: rename "from" to "funder" test: add visibility for "streamId" test variable test: update tests to account for the contract refactor Closes #67
PaulRBerg
force-pushed
the
refactor/merge-create-functions
branch
from
4bbac8c
to
d376d04
Compare
This was referenced Jun 21, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67. Checklist:
createandcreateFromfunctions- - Test the case when thefunderdoes not match themsg.sender(as explained in Test the "createFrom" and "createFromWithDuration" functions #49)fundermatches themsg.senderDepends upon #71 being merged first.
Update: I have stricken through the 2nd item above as per my argument put forth in #74 that the authorization system is not needed anymore.