-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added option to load meta data #123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Shouldn't we put the first part into OmnipathR, so there is an easy option to extract these columns for those who don't use DecoupleR?
@@ -104,6 +106,7 @@ get_collectri <- function(organism='human', split_complexes=FALSE, ...){ | |||
organism = organism, | |||
genesymbol=TRUE, | |||
loops=TRUE, | |||
extra_attrs = TRUE, | |||
... | |||
), | |||
error = function(e){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fallback won't have the extra_attrs
column (though we can include it in the future). It raises a warning, so the user will be aware. Optionally we can handle the rare case when this happens with load_meta = TRUE
.
"mor" = weight, | ||
) | ||
|
||
if (!load_meta){ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit too much duplication, only little differences between the two branches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, I think we can merge this :)
Added a parameter to load the additional meta data (resources, PMIDs, sign decision, TF class) for CollecTRI.