Improve comment regarding settlement check

[iamacook]

Summary

We do not check the transaction data when mapping a swap transfer to ensure it is a settle call. The addition of this check was marked with a TODO.

Having looked into the inclusion of this showed that we do not always have access to the transaction data, e.g. when getting all incoming transfers, we only have the Transfer. As such, a detailed comment as been added explaining this, including assurance that the current implementation is sufficient.

Changes

• Rename method to be more declarative
• Improve comment

[coveralls]

Pull Request Test Coverage Report for Build 9842951190

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage remained the same at 48.257%

---

Files with Coverage Reduction	New Missed Lines	%
src/routes/transactions/mappers/transfers/swap-transfer-info.mapper.ts	1	13.64%

Totals
Change from base Build 9840890988:	0.0%
Covered Lines:	4225
Relevant Lines:	7022

---

💛 - Coveralls