Implement Counterfactual Safes creation rate limit #1801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 10281742208Details
💛 - Coveralls |
hectorgomezv
commented
Aug 5, 2024
| { length: creationRateLimitCalls }, | ||
| (_, i) => | ||
| createCounterfactualSafeDtoBuilder() | ||
| .with('chainId', i.toString()) |
There was a problem hiding this comment.
chainId is set as a discriminator to avoid the DTO properties collision edge case.
iamacook
reviewed
Aug 6, 2024
There was a problem hiding this comment.
As with the other implementation for accounts, this seems more guard-like behaviour? It might even allow us to reduce repetition if it was in a guard. What do you think?
I've answered in #1800 (comment), we can follow the discussion there if you are happy with it. |
iamacook
previously approved these changes
Aug 7, 2024
hectorgomezv
force-pushed
the
add-cf-safes-creation-rate-limit
branch
from
e08697c
to
9ca3900
Compare
iamacook
approved these changes
Aug 7, 2024
DenSmolonski
pushed a commit
to Zilliqa/safe-client-gateway
that referenced
this pull request
Oct 24, 2024
Adds a rate limitation controlled by a cache key before proceeding with Counterfactual Safes creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a rate limitation to creating Counterfactual Safes using the related
CounterfactualSafesControllerendpoint. This rate limit is applied by taking theAccountassociated with the Counterfactual Safe to calculate the limit threshold.Changes