From 643a6737c1242995eded2aaad5d5ce683ddf8bdf Mon Sep 17 00:00:00 2001 From: katspaugh Date: Thu, 21 Nov 2024 12:53:10 +0100 Subject: [PATCH 1/2] Fix: remove old app store button --- public/images/common/appstore-light.svg | 1 - public/images/common/appstore.svg | 1 - .../common/AppStoreButton/index.tsx | 34 ------------------- src/components/common/Footer/index.tsx | 4 --- .../analytics/events/mobileAppPromotion.ts | 8 ----- 5 files changed, 48 deletions(-) delete mode 100644 public/images/common/appstore-light.svg delete mode 100644 public/images/common/appstore.svg delete mode 100644 src/components/common/AppStoreButton/index.tsx delete mode 100644 src/services/analytics/events/mobileAppPromotion.ts diff --git a/public/images/common/appstore-light.svg b/public/images/common/appstore-light.svg deleted file mode 100644 index a21ad045c4..0000000000 --- a/public/images/common/appstore-light.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/public/images/common/appstore.svg b/public/images/common/appstore.svg deleted file mode 100644 index 1dbcc9769e..0000000000 --- a/public/images/common/appstore.svg +++ /dev/null @@ -1 +0,0 @@ - \ No newline at end of file diff --git a/src/components/common/AppStoreButton/index.tsx b/src/components/common/AppStoreButton/index.tsx deleted file mode 100644 index 65fe9eb30a..0000000000 --- a/src/components/common/AppStoreButton/index.tsx +++ /dev/null @@ -1,34 +0,0 @@ -import type { ReactElement } from 'react' -import Image from 'next/image' - -import { useDarkMode } from '@/hooks/useDarkMode' -import { MOBILE_APP_EVENTS, trackEvent } from '@/services/analytics' - -// App Store campaigns track the user interaction -enum LINKS { - footer = 'https://apps.apple.com/app/apple-store/id1515759131?pt=119497694&ct=Web%20App%20Footer&mt=8', -} - -const AppstoreButton = ({ placement }: { placement: keyof typeof LINKS }): ReactElement => { - const isDarkMode = useDarkMode() - - const onClick = () => { - trackEvent({ - ...MOBILE_APP_EVENTS.APPSTORE_BUTTON_CLICK, - label: placement, - }) - } - - return ( - - Download on the App Store - - ) -} - -export default AppstoreButton diff --git a/src/components/common/Footer/index.tsx b/src/components/common/Footer/index.tsx index 10a27177eb..de2d36f115 100644 --- a/src/components/common/Footer/index.tsx +++ b/src/components/common/Footer/index.tsx @@ -6,7 +6,6 @@ import { useRouter } from 'next/router' import css from './styles.module.css' import { AppRoutes } from '@/config/routes' import packageJson from '../../../../package.json' -import AppstoreButton from '../AppStoreButton' import ExternalLink from '../ExternalLink' import MUILink from '@mui/material/Link' import { HELP_CENTER_URL, IS_DEV, IS_OFFICIAL_HOST } from '@/config/constants' @@ -83,9 +82,6 @@ const Footer = (): ReactElement | null => { v{packageJson.version} -
  • - -
    • ) diff --git a/src/services/analytics/events/mobileAppPromotion.ts b/src/services/analytics/events/mobileAppPromotion.ts deleted file mode 100644 index e5bdb05c90..0000000000 --- a/src/services/analytics/events/mobileAppPromotion.ts +++ /dev/null @@ -1,8 +0,0 @@ -const MOBILE_APP_CATEGORY = 'mobile-app-promotion' - -export const MOBILE_APP_EVENTS = { - APPSTORE_BUTTON_CLICK: { - action: 'appstore-button-click', - category: MOBILE_APP_CATEGORY, - }, -} From 95d77d8a57181b0cf48cb13ef0f23bea676dcee2 Mon Sep 17 00:00:00 2001 From: katspaugh Date: Thu, 21 Nov 2024 13:15:28 +0100 Subject: [PATCH 2/2] Rm import --- src/services/analytics/events/index.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/src/services/analytics/events/index.ts b/src/services/analytics/events/index.ts index 7edb89c9e3..af373e8450 100644 --- a/src/services/analytics/events/index.ts +++ b/src/services/analytics/events/index.ts @@ -1,7 +1,6 @@ export * from './addressBook' export * from './assets' export * from './createLoadSafe' -export * from './mobileAppPromotion' export * from './modals' export * from './overview' export * from './safeApps'