Refactor: rm unnecessary tx decoding #4541
Conversation
Branch preview✅ Deploy successful! Website: Storybook: |
📦 Next.js Bundle Analysis for safe-wallet-webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 🎉 Global Bundle Size Decreased
DetailsThe global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster. Any third party scripts you have added directly to your app using the If you want further insight into what is behind the changes, give @next/bundle-analyzer a try! |
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success1618 tests passing in 217 suites. Report generated by 🧪jest coverage report action from 4ba74ef |
|
Counterfactual Safes cannot create transactions, so all good. |
katspaugh
requested review from
usame-algan
and removed request for
clovisdasilvaneto
| function SwapOrder({ txDetails, txInfo }: SwapOrderProps) { | ||
| return ( | ||
| <SwapOrderConfirmation | ||
| order={txInfo as unknown as AnySwapOrderConfirmationView} | ||
| settlementContract={txDetails?.txData?.to?.value ?? ''} | ||
| /> | ||
| ) | ||
| } |
There was a problem hiding this comment.
I've checked the usage of SwapOrder and we only use it in places where we have guards for checking txInfo. Can't we type txInfo here to be more narrow (i.e. Order) instead of still resolving to TransactionInfo? That way we wouldn't need to cast.
This would match the structure of StakingTxProps
Co-authored-by: Usame Algan <5880855+usame-algan@users.noreply.github.com>
What it solves
A follow-up on #4177 that partially addresses #4331.
How it solves it
How to test it
All the txs should work exactly as before.