From d4f56d4da10a4ed23a1daa6841b685daee2464c4 Mon Sep 17 00:00:00 2001 From: sagautam5 Date: Sun, 7 Apr 2024 14:03:12 +0545 Subject: [PATCH] set phpstan level to 3 and update code --- .github/workflows/ci.yml | 2 +- src/Entities/Category.php | 4 ++-- src/Entities/Province.php | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 899ad13..a486e28 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -22,4 +22,4 @@ jobs: - name: Run PHPUnit tests run: vendor/bin/phpunit - name: Run PhpStan Analyse Code - run: vendor/bin/phpstan analyse --level=2 src tests \ No newline at end of file + run: vendor/bin/phpstan analyse --level=3 src tests \ No newline at end of file diff --git a/src/Entities/Category.php b/src/Entities/Category.php index e0bdf73..38791ab 100644 --- a/src/Entities/Category.php +++ b/src/Entities/Category.php @@ -45,7 +45,7 @@ public function allCategories() * Find category by id * * @param $id - * @return false|int|string + * @return object|null */ public function find($id) { @@ -58,7 +58,7 @@ public function find($id) * Find category by short code * * @param $short_code - * @return string|null + * @return object|null */ public function findByShortCode($short_code) { diff --git a/src/Entities/Province.php b/src/Entities/Province.php index 112769d..2fea09c 100644 --- a/src/Entities/Province.php +++ b/src/Entities/Province.php @@ -45,7 +45,7 @@ public function allProvinces() * Find province by id * * @param $id - * @return false|int|string + * @return object|null */ public function find($id) {