Skip to content

Commit 1c3f991

Browse files
author
Release Manager
committed
gh-37489: Fix failing docstring in random testing for `quaternion_algebra.py` The current code: ```py sage: set_random_seed(558346185206384723433409773377632267) sage: q = randrange(1,1000) ....: p = randrange(1,1000) ....: Quat.<i,j,k> = QuaternionAlgebra(-q, -p) ....: O0 = Quat.maximal_order() ....: while True: ....: b = Quat.random_element() ....: if gcd(b.reduced_norm(), Quat.discriminant()) == 1: ....: break ....: O1 = (b * O0).left_order() ....: iso = O0.isomorphism_to(O1); iso Ring endomorphism of Order of Quaternion Algebra (-667, -662) with base ring Rational Field with basis (1, 1/2 + 1/2*i, j, 1/2 + 11/58*i + 1/2*j + 1/58*k) Defn: i |--> i j |--> j k |--> k sage: O0 Order of Quaternion Algebra (-667, -662) with base ring Rational Field with basis (1, 1/2 + 1/2*i, j, 1/2 + 11/58*i + 1/2*j + 1/58*k) sage: O1 Order of Quaternion Algebra (-667, -662) with base ring Rational Field with basis (1, 1/2 + 1/2*i, j, 1/2 + 11/58*i + 1/2*j + 1/58*k) ``` Causes a doctest to fail as a `Ring morphism` is expected but when `O0 == O1` then instead a `Ring endomorphism` is computed instead. We simply truncate the expected output for the random testing from `Ring morphism` to `Ring ...` fixing the failure. ``` sage -t --random-seed=558346185206384723433409773377632267 src/sage/algebras/quatalg/quaternion_algebra.py [562 tests, 17.35 s] ---------------------------------------------------------------------- All tests passed! ---------------------------------------------------------------------- Total time for all tests: 18.7 seconds cpu time: 15.6 seconds cumulative wall time: 17.3 seconds ``` Fixes #37488 URL: #37489 Reported by: Giacomo Pope Reviewer(s): Lorenz Panny
2 parents b84c50c + 949d94e commit 1c3f991

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/sage/algebras/quatalg/quaternion_algebra.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2332,7 +2332,7 @@ def isomorphism_to(self, other, *, conjugator=False, B=10):
23322332
....: break
23332333
sage: O1 = (b * O0).left_order()
23342334
sage: iso = O0.isomorphism_to(O1); iso
2335-
Ring morphism: ...
2335+
Ring ...
23362336
sage: iso.domain() == O0
23372337
True
23382338
sage: iso.codomain() == O1

0 commit comments

Comments
 (0)