Skip to content

Commit

Permalink
Fix failing tests
Browse files Browse the repository at this point in the history
  • Loading branch information
@user202729
user202729 committed Nov 12, 2024
1 parent a7455b1 commit b71e491
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions src/sage/schemes/elliptic_curves/ell_field.py
View file
Original file line number Diff line number Diff line change
Expand Up @@ -1559,7 +1559,7 @@ def period_lattice(self):
sage: EllipticCurve(QQbar, [1, 6]).period_lattice()
Period lattice associated to Elliptic Curve defined by y^2 = x^3 + x + 6 over Algebraic Field
Unsupported cases::
Unsupported cases (the exact error being raised may change in the future)::
sage: EllipticCurve(ZZ, [1, 6]).period_lattice()
Traceback (most recent call last):
Expand All @@ -1569,11 +1569,9 @@ def period_lattice(self):
sage: EllipticCurve(QQt.fraction_field(), [1, 6]).period_lattice()

Check failure on line 1569 in src/sage/schemes/elliptic_curves/ell_field.py

View workflow job for this annotation

GitHub Actions / test-new

Failed example: 

Failed example:: Exception raised:
Traceback (most recent call last):
  File "sage/structure/category_object.pyx", line 857, in sage.structure.category_object.CategoryObject.getattr_from_category
    return self._cached_methods[name]
KeyError: 'embeddings'

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/sage/src/sage/doctest/forker.py", line 715, in _run
    self.compile_and_execute(example, compiler, test.globs)
  File "/sage/src/sage/doctest/forker.py", line 1136, in compile_and_execute
    exec(compiled, globs)
  File "<doctest sage.schemes.elliptic_curves.ell_field.EllipticCurve_field.period_lattice[10]>", line 1, in <module>
    EllipticCurve(QQt.fraction_field(), [Integer(1), Integer(6)]).period_lattice()
  File "/sage/src/sage/schemes/elliptic_curves/ell_field.py", line 1577, in period_lattice
    return PeriodLattice_ell(self)
  File "/sage/src/sage/schemes/elliptic_curves/period_lattice.py", line 243, in __init__
    embs = K.embeddings(AA)
  File "sage/structure/category_object.pyx", line 851, in sage.structure.category_object.CategoryObject.__getattr__
    return self.getattr_from_category(name)
  File "sage/structure/category_object.pyx", line 866, in sage.structure.category_object.CategoryObject.getattr_from_category
    attr = getattr_from_other_class(self, cls, name)
  File "sage/cpython/getattr.pyx", line 358, in sage.cpython.getattr.getattr_from_other_class
    raise AttributeError(dummy_error_message)
AttributeError: 'FractionField_1poly_field_with_category' object has no attribute 'embeddings'. Did you mean: 'an_embedding'?
Traceback (most recent call last):
...
AttributeError: 'FractionField_1poly_field_with_category' object has no attribute 'embeddings'
sage: EllipticCurve(GF(7), [1, 6]).period_lattice()

Check failure on line 1572 in src/sage/schemes/elliptic_curves/ell_field.py

View workflow job for this annotation

GitHub Actions / test-new

Failed example: 

Failed example:: Exception raised:
Traceback (most recent call last):
  File "/sage/src/sage/doctest/forker.py", line 715, in _run
    self.compile_and_execute(example, compiler, test.globs)
  File "/sage/src/sage/doctest/forker.py", line 1136, in compile_and_execute
    exec(compiled, globs)
  File "<doctest sage.schemes.elliptic_curves.ell_field.EllipticCurve_field.period_lattice[11]>", line 1, in <module>
    EllipticCurve(GF(Integer(7)), [Integer(1), Integer(6)]).period_lattice()
  File "/sage/src/sage/schemes/elliptic_curves/ell_field.py", line 1577, in period_lattice
    return PeriodLattice_ell(self)
  File "/sage/src/sage/schemes/elliptic_curves/period_lattice.py", line 247, in __init__
    embedding = embs[0]
IndexError: list index out of range
Traceback (most recent call last):
...
AttributeError: 'FiniteField_prime_modn_with_category' object has no attribute 'embeddings'
"""
from sage.schemes.elliptic_curves.period_lattice import PeriodLattice_ell
return PeriodLattice_ell(self)
Expand Down

0 comments on commit b71e491

Please sign in to comment.