sagemath_environment must respect --enable-system-site-packages #38190
Labels
Milestone
Comments
|
it is a blocker if any use is made of |
|
more precisely it could be used with another experimental package, but not with optional or standard. |
|
As you see, this bug (two bugs in one - dependency on an exterimental package + breaking of these, For the other ones, something needs to be done. The most natural is to fix |
no, this is not correct, apologies. The breaking changes came from #35661 - @kiwifb : you didn't notice there that it made a number of optional packages dependent upon an experimental package, And it has broken |
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Jun 16, 2024
…,repl}: Change to optional
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
... from "experimental".
As suggested in
sagemath#38190 (comment)
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38200
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Jun 16, 2024
…,repl}: Change to optional
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
... from "experimental".
As suggested in
sagemath#38190 (comment)
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38200
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
vbraun
pushed a commit
to vbraun/sage
that referenced
this issue
Jun 17, 2024
…,repl}: Change to optional
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->
... from "experimental".
As suggested in
sagemath#38190 (comment)
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
URL: sagemath#38200
Reported by: Matthias Köppe
Reviewer(s): Kwankyu Lee
|
with 10.4.rc1, the issue is still here: So an optional package ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Steps To Reproduce
Trigger building
sagemath_environment, e.g. (after applying #38163) bymake sagemath_tdlib, or from scratch, bythen, assuming that either
setuptoolsorwheelpackages come from the system, it will fail, as observed on #38159 (comment)Expected Behavior
should work
Actual Behavior
in does not.
Additional Information
There is a lookup happening for wheels for setuptools and wheel - something that is almost sure to fail if the latter come from the system.
Environment
Checklist
The text was updated successfully, but these errors were encountered: