-
-
Notifications
You must be signed in to change notification settings - Fork 490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build/bin/sage-spkg
: Add support for installing script packages
#36747
build/bin/sage-spkg
: Add support for installing script packages
#36747
Conversation
… exist (script package)
ca92398
to
6be9ba0
Compare
build/bin/sage-spkg
: Add support for installing script packages, pip packagesbuild/bin/sage-spkg
: Add support for installing script packages
d15561b
to
e35a72e
Compare
e35a72e
to
c008841
Compare
I get two errors under "normal" circumstances that don't hurt anything:
The retry works, but the error is in bright red and always happens AFAICT so it would be better if, well, it didn't. It may have something to do with The other error can probably be fixed with an
|
The first try uses build isolation, so it needs the wheel file of setuptools. |
... so perhaps when using |
How do you provoke this error? I don't see it |
The reinstall may not be necessary, but those were the steps I used. |
I think so. Is there an easy way to do this across the board? If not, it's not that big of a deal. The |
My https://gitweb.michael.orlitzky.com/?p=bash.d.git;a=blob;f=sage.sh;hb=HEAD I've obviously got |
Oh, that's #36737. I'll merge it here |
…ipt_packages_via_sage_spkg
It all goes through |
Yep, that fixed it. |
sage-logger -p '$$(SAGE_ROOT)/build/pkgs/$(1)/spkg-install && if [ $$$$SAGE_CHECK != no -a -x $$(SAGE_ROOT)/build/pkgs/$(1)/spkg-check ]; then $$(SAGE_ROOT)/build/pkgs/$(1)/spkg-check; fi' '$$(SAGE_LOGS)/$(1)-$(2).log' && \ | ||
rm -f "$$($(4))/$(SPKG_INST_RELDIR)/$(1)"-* && \ | ||
touch "$$($(4))/$(SPKG_INST_RELDIR)/$(1)-$(2)"; \ | ||
sage-logger -p 'SAGE_CHECK=$$(SAGE_CHECK_$(1)) PATH=$$(SAGE_SRC)/bin:$$($(4))/bin:$$$$PATH $$(SAGE_SPKG) $$(SAGE_SPKG_OPTIONS) \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$$$$PATH 💪
Thank you! |
merge conflict |
…spkg SageMath version 10.3.beta1, Release Date: 2023-12-10
4cde017
to
32d95d2
Compare
Documentation preview for this PR (built with commit 32d95d2; changes) is ready! 🎉 |
<!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> `make SPKG-check` runs the testsuite of `SPKG` via sage-spkg. This builds on - sagemath#36738 - sagemath#36747 <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [ ] The title is concise, informative, and self-explanatory. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#37022 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee, Matthias Köppe
Split out and updated from #29386.
The section of
build/make/Makefile.in
that deals with script packages can be consolidated with the section on normal packages later, in a follow-up PR after #36740, #36738.We switch the
spkg-install
scripts of thesage*
script packages to the templated versions (spkg-install.in
), which is a simplification.spkg-check
remains as is because we still invoke it directly (changing this will need #36738).Resolves #29386.
📝 Checklist
⌛ Dependencies
make SPKG-uninstall
for Python packages after #36452 #36737 (for testing)